fix(dra): support Deckhouse GPU attributes#130
Open
danilrwx wants to merge 2 commits into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The KubeVirt DRA status controller only recognized the upstream Kubernetes GPU device attributes (
resource.kubernetes.io/pcieRoot,resource.kubernetes.io/mDevUUID). A GPU published by the Deckhouse GPU DRA driver under its own namespaced attributes (gpu.deckhouse.io/pciAddress,gpu.deckhouse.io/deviceType,gpu.deckhouse.io/sharingStrategy) could not be resolved into a GPU status, so VM GPU passthrough based on the Deckhouse driver did not work.After this PR:
The DRA status controller understands the Deckhouse GPU attributes in addition to the upstream ones, and validates that an allocated GPU is safe for VM passthrough:
gpu.deckhouse.io/pciAddress,gpu.deckhouse.io/deviceType(physical/mig), andgpu.deckhouse.io/sharingStrategy;allowMultipleAllocations, use any sharing strategy, are MIG without anmDevUUID, or expose a PCI address with a non-physical device type;References
Why we need it and why it was done in this way
The Deckhouse GPU DRA driver publishes device attributes under the
gpu.deckhouse.io/namespace rather thanresource.kubernetes.io/. The virtualization module selects GPUs byproductNameand only accepts exclusive physical devices, so KubeVirt must read the Deckhouse attributes and enforce the same exclusivity constraints as a safety layer.The following tradeoffs were made:
The following alternatives were considered:
resource.kubernetes.io/keys — rejected to keep driver-specific metadata namespaced and avoid collisions with other DRA drivers.Links to places where the discussion took place: deckhouse/virtualization#2520
Special notes for your reviewer
Deckhouse-only downstream change. Tracked under the deckhouse/virtualization GPU DRA effort. The unrelated
chore(lint): migrate golangci config to v2commit is bundled on this branch.Checklist
Release note